search

eth-protocol-fellows / protocol-studies

A study group learning about Ethereum and building protocol wiki
Other
130 stars 81 forks source link

EPF wiki template doesn't render mermaid script or references in ePBS page #173

Closed thogiti closed 3 months ago

thogiti commented 3 months ago

Our current EPF wiki template doesn't render mermaid script. It also doesn't display references at the end of page.

For a temporary fix, I will update the ePBS to have a static image instead of mermaid script rendering and add a section for Resources.

https://epf.wiki/#/wiki/research/PBS/ePBS

I will work on it this weekend.

shyam-patel-kira commented 3 months ago

Our current EPF wiki template doesn't render mermaid script. It also doesn't display references at the end of page.

For a temporary fix, I will update the ePBS to have a static image instead of mermaid script rendering and add a section for Resources.

https://epf.wiki/#/wiki/research/PBS/ePBS

I will work on it this weekend.

Would it be beneficial to add images instead of mermaid script? And the subtitle in image can be linked to the mermaid scripts.

thogiti commented 3 months ago

Our current EPF wiki template doesn't render mermaid script. It also doesn't display references at the end of page. For a temporary fix, I will update the ePBS to have a static image instead of mermaid script rendering and add a section for Resources. https://epf.wiki/#/wiki/research/PBS/ePBS I will work on it this weekend.

Would it be beneficial to add images instead of mermaid script? And the subtitle in image can be linked to the mermaid scripts.

Thx @shyam-patel-kira. Pushing a commit with static images in few minutes.

taxmeifyoucan commented 3 months ago

Thanks for bringing this up, I didn't realize it's missing in Docsify. I added a plugin for mermaid scripts and it should all render correctly now. Example from ePBS image

thogiti commented 3 months ago

Cool. Thx @taxmeifyoucan.

Do we need another wiki-pages merge to see this change in the production?