eth-protocol-fellows / protocol-studies

A study group learning about Ethereum and building protocol wiki
Other
130 stars 81 forks source link

Adding static images hosting and resources section #175

Closed thogiti closed 3 months ago

thogiti commented 3 months ago

Wiki PR Checklist

github-actions[bot] commented 3 months ago

Hi @thogiti,

Following typos were found in the pull request:

ℹī¸ Here's how to fix them:

thogiti commented 3 months ago

@taxmeifyoucan Updated the ePBS.md for hosting static images and a resources section to make the references visible.

taxmeifyoucan commented 3 months ago

Are you sure you don't want to use the mermaid instead? It's more effective to host than pictures and easier to edit

thogiti commented 3 months ago

Are you sure you don't want to use the mermaid instead? It's more effective to host than pictures and easier to edit

I like mermaid script based rendering because Github automatically adds some zoom/pan controls and the text and objects are responsive to the device resolution.

I will make another commit to put the mermaid code back.

thogiti commented 3 months ago

Added back the mermaid scripts to render PTC and PEPC workflows in this commit. https://github.com/eth-protocol-fellows/protocol-studies/pull/178/commits/389faa914aefd5f933c4b049036b9712665d54cb

We can close this PR (delete it) because everything is included in the epbs specs PR at https://github.com/eth-protocol-fellows/protocol-studies/pull/178