search

eth-protocol-fellows / protocol-studies

A study group learning about Ethereum and building protocol wiki
Other
144 stars 87 forks source link

✨ feat(Week 10D): Links #204

Closed raxhvl closed 5 months ago

raxhvl commented 5 months ago

Wiki PR Checklist

Links updated.

github-actions[bot] commented 5 months ago

Hi @raxhvl,

Following typos were found in the pull request:

ℹ️ Here's how to fix them:

raxhvl commented 5 months ago

HI @thogiti could review these jargons specific to KZG and Preconfs and them to wordlist?

thogiti commented 5 months ago

📄 ./docs/wiki/research/Preconfirmations/BasedSequencingPreconfs.md:

I pushed a new PR with the updated wordlist.txt file. https://github.com/eth-protocol-fellows/protocol-studies/pull/206

Not sure what happened and why the updated `wordlist.txt wasn't added in the previous merge. No worries. The above PR has updated wordlist.

thogiti commented 5 months ago

@raxhvl What is the version number of aspell on the server side?

I just saw Github action failed the spellcheck for a single word Parallelization but it was passing ok locally.

thogiti commented 5 months ago

Ok, now spellcheck is passing. https://github.com/eth-protocol-fellows/protocol-studies/pull/206

raxhvl commented 5 months ago

Thank you!

I just saw Github action failed the spellcheck for a single word Parallelization but it was passing ok locally.

What caused this? Was it version diff? I believe the action uses latest version.

thogiti commented 5 months ago

Thank you!

I just saw Github action failed the spellcheck for a single word Parallelization but it was passing ok locally.

What caused this? Was it version diff? I believe the action uses latest version.

Here is the exact command I am running locally with all the flags: for f in **/*.md ; do echo $f ; aspell --lang=en_US --mode=markdown --home-dir=. --personal=wordlist.txt --ignore-case=true --camel-case list < $f | sort | uniq -c ; done

Here is the version I have locally:

image