Fix devp2p section on architecture-overview.png diagram.

eth-protocol-fellows / protocol-studies

A study group learning about Ethereum and building protocol wiki

Other

130 stars 81 forks source link

Fix devp2p section on architecture-overview.png diagram. #228

Closed meldsun0 closed 2 months ago

meldsun0 commented 2 months ago

What content is missing?

The diagram shows that devp2p uses UDP. While this is true, it is only on the discovery phase. During runtime (when sending messages around ) it uses TCP.

Here is diagrama: https://github.com/eth-protocol-fellows/protocol-studies/blob/main/docs/images/el-architecture/architecture-overview.png
Here is referenced: https://github.com/eth-protocol-fellows/protocol-studies/blob/main/docs/wiki/EL/el-architecture.md

@SiddharthV1 I guess you contributed on this. Can you take a look?

Other relevant resources

SiddharthV1 commented 2 months ago

@meldsun0 That's great that you found an issue that fast please have look if you'd like to fix it here is the excalidraw file: https://github.com/eth-protocol-fellows/protocol-studies/blob/main/docs/images/el-architecture/excalidraw/reth-architecture-overview.excalidraw... there is a branch dedicated to el-architecture, you can direct the PR to that branch

SiddharthV1 commented 2 months ago

@meldsun0 Apologies, I misread your you for an I last night .... yes I will take a look and fix it, thanks for letting me know

SiddharthV1 commented 2 months ago

Closing the issue, since it's resolved when #232 got merged from the el-architecture branch, which contained the Image fix

meldsun0 commented 2 months ago

Great thanks! If you need some help! Let me know.