🐞 fix: Content text color

eth-protocol-fellows / protocol-studies

A study group learning about Ethereum and building protocol wiki

Other

130 stars 81 forks source link

🐞 fix: Content text color #252

Closed raxhvl closed 1 month ago

raxhvl commented 2 months ago

[x] Fixes a readability issue with text on some browsers.
[x] Typos

github-actions[bot] commented 2 months ago

Hi @raxhvl,

Following typos were found in the pull request:

📄 ./docs/contributing.md:
1. blockquote
📄 ./notes/wiki_contributors_meeting/2024-05-02_release_plan.md:
1. publically

ℹ️ Here's how to fix them:

Fix typos: Open the relevant files and fix any identified typos.
Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root. Each word should be listed on a separate line. Learn more.
🚧 Remember:
- When adding new words it MUST NOT have any spaces or special characters within or around it.
- wordlist is NOT case sensitive.
- Use backticks to quote code variables so as to not bloat the wordlist.

taxmeifyoucan commented 2 months ago

@biafra23 Can you please give one a test before we merge?

biafra23 commented 2 months ago

How do I test this before you merge?

raxhvl commented 2 months ago

Preview changes on this link: https://epf-wiki-git-fix-theme-text-color-0xrahls-projects.vercel.app/

taxmeifyoucan commented 2 months ago

Here is the difference in my browser. The body of text is not just brighter but also bigger. What do you think about setting a slightly dimmer or smaller font for the body? Something in between these two.

biafra23 commented 2 months ago

Firefox on MacOS:

The main text is fine. But the headlines are not.

taxmeifyoucan commented 2 months ago

Thanks a lot Dirk!

@raxhvl Let's divide it into style for Hs, body, sidebar so we can define slight differences between each.

raxhvl commented 1 month ago

I'm unable to reproduce this on my mac + firefox setup. Here is how the production site renders:

@raxhvl Let's divide it into style for Hs, body, sidebar so we can define slight differences between each.

Sure.

raxhvl commented 1 month ago

@taxmeifyoucan I have adjusted the color. Headings are white, content is few shades darker. You could fine tune here: https://github.com/eth-protocol-fellows/protocol-studies/blob/91b8d1568a6a95422336fdb779bec2ae78b9ac46/docs/assets/css/custom.css#L175-L177

Preview link: https://epf-wiki-git-fix-theme-text-color-0xrahls-projects.vercel.app/#/

taxmeifyoucan commented 1 month ago

Great, thanks a lot Rahul! Looks good in my browser.

@biafra23 Can you please check again whether it looks all good now?

biafra23 commented 1 month ago

Looks good for me (Firefox & Chrome on macOS):

taxmeifyoucan commented 1 month ago

Awesome, thanks a lot guys!