eth-sri / ELINA

ELINA: ETH LIbrary for Numerical Analysis
http://elina.ethz.ch/
Other
129 stars 54 forks source link

Add ./configure option to suppress overflow warnings #52

Closed jmct closed 4 years ago

jmct commented 4 years ago

This addresses part of the concerns in issue #39. Namely, if we know the overflow is sound, then we can choose to skip printing to stderr when the sound overflow occurs.

The implementation is straightforward:

jmct commented 4 years ago

One thing that I'm not sure about is whether all the occurrences of ELINA_EXC_OVERFLOW are sound in the same way.

GgnDpSngh commented 4 years ago

Hi Jose,

Thanks for the update. Whenever there is an overflow our implementation tries to handle it in a sound way by setting the exception flag. This is detected in the calling method which sets the corresponding polyhedron to Top.

There has been recent work (https://dl.acm.org/citation.cfm?doid=3238147.3240464) that tested ELINA's soundness guarantees on challenging inputs. Many of these inputs generate test cases where one observes overflows and helped us fix issues. Ofcourse, there can be control paths that we may have missed and if you observe any unsoundness, let me know.

Cheers, Gagandeep Singh