search

eth-sri / ELINA

ELINA: ETH LIbrary for Numerical Analysis
http://elina.ethz.ch/
Other
129 stars 54 forks source link

Fixing compiler errors when TIMING disabled and fixing some memory leaks #72

Closed cwright7101 closed 3 years ago

cwright7101 commented 3 years ago

Fixing some compiler errors (when compiling with clang), and fixing some memory leaks for poly

GgnDpSngh commented 3 years ago

Hi Christopher,

Thanks for the pull request, it looks fine. I had one comment about the TIMING changes. Shouldn't

if (TIMING) be #if defined(TIMING)?

Cheers, Gagandeep Singh

deepcodeappdev[bot] commented 3 years ago

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that. Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

ghost commented 3 years ago

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that. Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

cwright7101 commented 3 years ago

Yes you are correct, it should probably be #if defined (TIMING), in C it will work because the flags are really just 0/1, but you should do the defined for readability. Did a force update of the commit but looks like you already accepted. Thanks!