search

eth-sri / securify

[DEPRECATED] Security Scanner for Ethereum Smart Contracts
Apache License 2.0
215 stars 50 forks source link

Add errors to output #30

Closed hiqua closed 5 years ago

hiqua commented 5 years ago

Related: #29.

hiqua commented 5 years ago

I only have one example of a smart contract that cannot be decompiled, I've tried to look for some (mostly on securify.ch) but couldn't find more in a limited time, so there could still be errors we don't add to the output. More examples welcome.

hiqua commented 5 years ago

@ptsankov if you have more examples let me know

MatthiasEgli-chainsecurity commented 5 years ago

@hiqua Please drop me a comment here once it is ready for another review

hiqua commented 5 years ago

@MatthiasEgli-chainsecurity There are still two open questions for you, so even if I update the code with the other points, it won't be ready to merge. I'll update the code regarding the other points when I have time.

hiqua commented 5 years ago

@MatthiasEgli-chainsecurity let me know once you've had time to look at it and answer my comments, nothing more to add from my side for now.

MatthiasEgli-chainsecurity commented 5 years ago

@hiqua done with comments. Core is the way we handle progress, the other comments are minor and just clean up some code debt.

hiqua commented 5 years ago

@MatthiasEgli-chainsecurity just added the final change, I wait for your final review and if it's good for you I'll rebase and merge.

ghost commented 5 years ago

DeepCode analyzed this pull request. There are no new issues.