[WIP] Decompiler Improvements

ritzdorf commented 5 years ago

Adding additional EVM instructions to allow better decompilation (Revert, Returndatasize, Returndatacopy, Staticcall, Invalid)
Hotfixing a bug that causes the intermediate representation to fail when a conditional jump is leading to two stack merges
Hotfixing another bug that causes the decompilation to crash in case of unbalanced stacks. Independently verified the jumps and the stack growth. They seem correct. A proper fix requires an slight adaptation in the abstraction.

Here is a breaking example for the first issue: https://gist.github.com/ritzdorf/7aaa2f59a3be273d1aab9ee4d929219b This should work now with the hotfix.

Generally, a lot more testing is needed.

ghost commented 5 years ago

DeepCode analyzed this pull request and found: 1 Info Suggestion.

Click here to see how others fixed these problems.

ghost commented 5 years ago

DeepCode analyzed this pull request and found: 1 Info Suggestion.

Click here to see how others fixed these problems.

hiqua commented 5 years ago

@ritzdorf are there other changes you want to add to this PR or is it no longer a WIP?

ritzdorf commented 5 years ago

Will finish it up today.

hiqua commented 5 years ago

Ok just remove the [WIP] from the title when you think it should be merged.

ritzdorf commented 5 years ago

@hiqua Ready for merge from my side.

ritzdorf commented 5 years ago

Found another case that is not covered by my fix. Will give a time estimate as soon as I can.

hiqua commented 5 years ago

@ritzdorf can you expand on this case here directly?

hiqua commented 5 years ago

Closing as discussed with @ritzdorf.

eth-sri / securify