Closed ritzdorf closed 5 years ago
DeepCode analyzed this pull request and found: 1 Info Suggestion.
Click here to see how others fixed these problems.
DeepCode analyzed this pull request and found: 1 Info Suggestion.
Click here to see how others fixed these problems.
@ritzdorf are there other changes you want to add to this PR or is it no longer a WIP?
Will finish it up today.
Ok just remove the [WIP] from the title when you think it should be merged.
@hiqua Ready for merge from my side.
Found another case that is not covered by my fix. Will give a time estimate as soon as I can.
@ritzdorf can you expand on this case here directly?
Closing as discussed with @ritzdorf.
Here is a breaking example for the first issue: https://gist.github.com/ritzdorf/7aaa2f59a3be273d1aab9ee4d929219b This should work now with the hotfix.
Generally, a lot more testing is needed.