search

eth-sri / securify

[DEPRECATED] Security Scanner for Ethereum Smart Contracts
Apache License 2.0
215 stars 50 forks source link

Added new EVM operations #40

Closed ritzdorf closed 5 years ago

ritzdorf commented 5 years ago

This is taken out of #32 and separated for faster merging.

The new EVM opcodes are

Currently the tests related to TODTransfer fail. However, this might be due to a bug in the pattern that was previously not detected by the test (because ReturnDataSize was missing).

@ptsankov or anyone with a better datalog understanding: Can you explain the semantics of this line (https://github.com/eth-sri/securify/blob/ritzdorf/add_evm_opcodes/src/main/java/ch/securify/patterns/TODTransfer.java#L81) because it returns false for this example, where I would expect it to return true: https://github.com/eth-sri/securify/blob/ritzdorf/add_evm_opcodes/src/test/resources/solidity/TODTransfer2.sol

ghost commented 5 years ago

DeepCode analyzed this pull request. There are no new issues.

hiqua commented 5 years ago

I'm wondering if we should go to the bottom of the failing TODTransfer test before we merge this.

MatthiasEgli-chainsecurity commented 5 years ago

Comment the broken test, add a new issue to track the underlying issue (pattern broken afaik), and merge this.