Feature request: let the user specify PATTERN_TIMEOUT

eth-sri / securify

[DEPRECATED] Security Scanner for Ethereum Smart Contracts

Apache License 2.0

216 stars 50 forks source link

Feature request: let the user specify PATTERN_TIMEOUT #73

Closed ggrieco-tob closed 5 years ago

ggrieco-tob commented 5 years ago

Even if you use the timeout command to control how much time securify should run, its subprocess (e.g. mustExplicit) keep running for a long time. So, It will be very useful to allow the user to specify this timeout:

https://github.com/eth-sri/securify/tree/b43c6573f70412ee252dd881c692141cfb9d3beb/src/main/java/ch/securify/analysis/Config.java#L23

hiqua commented 5 years ago

If the timeout is reached, the results are not meaningful, so I think it's fine to wait longer, until the user manually interrupts the process. Or is it rather #15 which is bothering you?

ggrieco-tob commented 5 years ago

Or is it rather #15 which is bothering you?

Yes. Sorry I couldn't find that issue before! Feel free to close this issue if you want.

hiqua commented 5 years ago

Great!