search

eth-sri / securify

[DEPRECATED] Security Scanner for Ethereum Smart Contracts
Apache License 2.0
216 stars 50 forks source link

added '--descriptions' flag to the wrapper #74

Closed f4z3r closed 5 years ago

f4z3r commented 5 years ago

The docker checks flags validity before compiling etc. It now allows the --descriptions flag as well.

ghost commented 5 years ago

DeepCode analyzed this pull request. There is 1 new info report.

Click to see more details.

hiqua commented 5 years ago

Is there a way to pass any argument we don't know about directly to Securify, instead of adding every option manually?

f4z3r commented 5 years ago

@hiqua Yes there is. Using parse_known_args(), however, if you pass invalid flags, the wrapper will compile etc, and only throw an exception or so after the compilation when the Java executable is called (which might be like 15 seconds later). So I guess it boils down if you want the wrapper to be easy to maintain, or if you want it to catch errors straight away.

hiqua commented 5 years ago

The error will be explicit enough, so I'd rather have better maintainability.

ghost commented 5 years ago

DeepCode analyzed this pull request. There are no new issues.1 info report was fixed.

Click to see more details.

f4z3r commented 5 years ago

@hiqua Ok so I added code to pass all unknown flags to the Java executable. I left the output validation we have right now. Do you want me to remove that? It might be interesting to leave the major flags in, just for the -h call on the docker.

As of now, the only flags necessary for the wrapper are -v and -q.