Decompilation Error with --truffle

TlxTejaswi commented 5 years ago

Hello,

While scanning my contract using Securify, I get the following message:

Processing contract: /project/contracts/ReputationBook.sol:ReputationBook
  Attempt to decompile the contract with methods...
  Failed to decompile methods. Attempt to decompile the contract without identifying methods...
  Decompilation failed.
Error in Securify
java.lang.NullPointerException
    at ch.securify.decompiler.DestackerFallback.findJumpCondition(DestackerFallback.java:403)
    at ch.securify.decompiler.DestackerFallback.handleStackMerging(DestackerFallback.java:356)
    at ch.securify.decompiler.DestackerFallback.decompile(DestackerFallback.java:205)
    at ch.securify.decompiler.DestackerFallback.decompile(DestackerFallback.java:201)
    at ch.securify.decompiler.DestackerFallback.decompile(DestackerFallback.java:238)
    at ch.securify.decompiler.DestackerFallback.decompile(DestackerFallback.java:216)
    at ch.securify.decompiler.DestackerFallback.decompile(DestackerFallback.java:238)
    at ch.securify.decompiler.DestackerFallback.decompile(DestackerFallback.java:238)
    at ch.securify.decompiler.DestackerFallback.decompile(DestackerFallback.java:131)
    at ch.securify.decompiler.DecompilerFallback.decompile(DecompilerFallback.java:73)
    at ch.securify.Main.decompileContract(Main.java:296)
    at ch.securify.Main.processHexFile(Main.java:160)
    at ch.securify.Main.processCompilationOutput(Main.java:129)
    at ch.securify.Main.mainFromCompilationOutput(Main.java:105)
    at ch.securify.Main.main(Main.java:241)
Error, skipping: /project/contracts/ReputationBook.sol:ReputationBook

As a result, Securify is skipping the contract that I want to scan.

Please help me address this.

hiqua commented 5 years ago

Could you send us your contract, or a minimal reproducible example?

TlxTejaswi commented 5 years ago

@hiqua Thanks for the quick response. Here is the truffle project we are trying to compile. Contract

For your reference, we have changed the Dockerfile to below. Because we were unable to compile truffle with old versions of nodejs.


FROM ubuntu:18.04

LABEL maintainer="contact@securify.ch"

# install basic packages
RUN apt-get update && apt-get install -y\
    software-properties-common\
    locales

# set correct locale
RUN locale-gen en_US.UTF-8
ENV LANG en_US.UTF-8
ENV LANGUAGE en_US:en
ENV LC_ALL en_US.UTF-8

# install souffle
RUN apt-get update &&\
        apt-get -y install\
        wget\
        gdebi

RUN mkdir /souffle
RUN wget -P /souffle/ https://github.com/souffle-lang/souffle/releases/download/1.4.0/souffle_1.4.0-1_amd64.deb &&\
        gdebi --n /souffle/souffle_1.4.0-1_amd64.deb

# install java and pip
RUN apt-get update && apt-get -y install\
        openjdk-8-jdk\
        python3-pip

COPY requirements.txt /tmp/
RUN pip3 install --user -r /tmp/requirements.txt

RUN mkdir /isolc
COPY scripts/isolc/* /isolc/
RUN cd / && python3 -m isolc.install_solc

# install truffle for project compilation
RUN apt-get install -y curl
RUN curl -sL https://deb.nodesource.com/setup_10.x | bash -
RUN apt install -y nodejs

ARG truffle="latest"
RUN npm install -g truffle@$truffle

WORKDIR /sec

# To cache gradle distribution
COPY gradlew settings.gradle /sec/
COPY gradle /sec/gradle/
RUN ./gradlew -v

# copy and compile securify
COPY . /sec

RUN ./gradlew jar

# Solidity example
COPY src/test/resources/solidity/transaction-reordering.sol /project/example.sol
RUN npm -v
RUN node -v
# run_securify.py allows arguments to be passed (e.g. "--truffle").
ENTRYPOINT ["python3", "docker_run_securify.py", "-p", "/project","--truffle"]

hiqua commented 5 years ago

I didn't try with your Dockerfile, but if you rebuild the docker container by removing the build/ folder before, it should work. Alternatively, you can just pull the latest version, where I added this folder to the .dockerignore file. Please let us know if it works!