eth-vaw-glaciology / GlacioTools.jl

MIT License
1 stars 0 forks source link

Refactor #14

Closed luraess closed 1 year ago

luraess commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -1.20 :warning:

Comparison is base (635abdc) 20.35% compared to head (908beae) 19.15%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14 +/- ## ========================================== - Coverage 20.35% 19.15% -1.20% ========================================== Files 6 5 -1 Lines 457 475 +18 ========================================== - Hits 93 91 -2 - Misses 364 384 +20 ``` | [Impacted Files](https://app.codecov.io/gh/eth-vaw-glaciology/GlacioTools.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eth-vaw-glaciology) | Coverage Δ | | |---|---|---| | [src/Alpine\_glaciers.jl](https://app.codecov.io/gh/eth-vaw-glaciology/GlacioTools.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eth-vaw-glaciology#diff-c3JjL0FscGluZV9nbGFjaWVycy5qbA==) | `0.00% <0.00%> (ø)` | | | [src/Rasters\_helpers.jl](https://app.codecov.io/gh/eth-vaw-glaciology/GlacioTools.jl/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eth-vaw-glaciology#diff-c3JjL1Jhc3RlcnNfaGVscGVycy5qbA==) | `0.00% <0.00%> (-2.05%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/eth-vaw-glaciology/GlacioTools.jl/pull/14/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eth-vaw-glaciology)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mauro3 commented 1 year ago

Is this a breaking change? If so, best discuss it briefly with Christophe.

luraess commented 1 year ago

No breaking change AFAICT

mauro3 commented 1 year ago

Probably should merge this?

luraess commented 1 year ago

Yes

luraess commented 1 year ago

This PR should additionally close #13 upon merge.