Remove globals from core to improve usage as a library - Githubissues

eth0izzle / shhgit

Ah shhgit! Find secrets in your code. Secrets detection for your GitHub, GitLab and Bitbucket repositories.

MIT License

3.84k stars 481 forks source link

Remove globals from core to improve usage as a library #99

Open tstromberg opened 2 years ago

tstromberg commented 2 years ago

This PR addresses some embedding issues I experienced with the core library:

Global sessions made it difficult to process multiple repositories simultaneous
Global flags made it equally difficult to have multiple configurations simultaneously
Hardcoded config.yaml name felt awkward (For instance, I prefer sshgit.yaml).

Please let me know if there are any improvements you would like me to make. Thanks for the excellent tool & library!