search

ethan-goh / pe

0 stars 0 forks source link

Differing results when trying "remark 1 r/r/admin" and "remark 1 r/ r/admin" #13

Open ethan-goh opened 1 week ago

ethan-goh commented 1 week ago

For the remark feature, when I am trying to add a remark without "r/" inside (e.g Friends), I am able to do "r/Friends" or "r/ Friends", however, this is not the case when I want to have r/ inside the remark, as when there is a whitespace between the desired tag and the prefix, duplicate prefixes are detected.

image.png

This can perhaps be fixed by adding another layer of check to trim any whitespace after the "r/" command.

nus-pe-script commented 3 days ago

Team's Response

Hi,

For duplicate tag validation, we utilised the original implementation from AB3, and it is not really something that we worked on throughout the project, or v1.6. As such, we believe this bug is out of scope. Thank you for helping us spot this!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I believe this is in scope as have r/{something} is a very valid tag (e.g, tagging someone as being involved with a reddit subforum). Furthermore, the team addressed this issue by bringing up "duplicate tag validation" , however, this is bug is regarding remark validation, not tag validation. Remarks are not included in the original implementation from AB3. As such, I think that the team's response is not relevant to my bug.