search

ethanbass / chromatographR

Toolset for the reproducible analysis of chromatography data in R (HPLC-DAD/UV, GC-FID).
https://ethanbass.github.io/chromatographR/
GNU General Public License v2.0
14 stars 2 forks source link

stripplot failure in get_peaktable #28

Closed BenDMoore closed 1 year ago

BenDMoore commented 1 year ago

Hi Ethan, I'm just getting familiar with your ChromatographR package and am very excited by it, so thanks, but haven't had any luck producing a stripplot with the argument plot_it=T in get_peaktable - most of the striplot code gets written to the console but nothing is plotted...is this a known bug?

ethanbass commented 1 year ago

Hi Ben, Thank you very much for pointing this out. It seems I broke the code for the plot a while ago, but I didn't realize it since I don't use that plot very often. This should be fixed by 53bec5e. I also added a test so I will notice if it breaks again. I think it should work for you now after you reinstall from the master branch (and reset your R session). Let me know! Ethan

BenDMoore commented 1 year ago

Thanks Ethan, I’ll check that out and let you know Cheers

Dr Ben Moore, Associate Professor | Ecologist Hawkesbury Institute for the Environment | Western Sydney University Hawkesbury Campus (Richmond), Building R2, Room 1.45 Postal address: Locked Bag 1797, Penrith 2751, NSW, Australia T: +61 (0)2 4570 1384 |M: +61 412 245474 E: @.**@.> Twitter: @blinkybenjy | web: www.uws.edu.au/hie/benmoore

[signature_757244822]

Western Sydney University acknowledges the Darug, Eora, Dharawal and Wiradjuri peoples and thanks them for their support of its work on their lands

From: Ethan Bass @.> Reply to: ethanbass/chromatographR @.> Date: Wednesday, 30 August 2023 at 12:43 To: ethanbass/chromatographR @.> Cc: Ben Moore @.>, Author @.***> Subject: [External] Re: [ethanbass/chromatographR] stripplot failure in get_peaktable (Issue #28)

Hi Ben, Thank you very much for pointing this out. It seems I broke the code for the plot a while ago, but I didn't realize it since I don't use that plot very often. This should be fixed by 53bec5ehttps://github.com/ethanbass/chromatographR/commit/53bec5ef75e34d6955cea912496618a692b326ea. I also added a test so I will notice if it breaks again. I think it should work for you now after you reinstall from the master branch (and reset your R session). Let me know! Ethan

— Reply to this email directly, view it on GitHubhttps://github.com/ethanbass/chromatographR/issues/28#issuecomment-1698403838, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7RAOHFKBKDKNMZMT3VDWWDXX2RXVANCNFSM6AAAAAA4DXXPPI. You are receiving this because you authored the thread.Message ID: @.***>

BenDMoore commented 1 year ago

It works! Thanks – useful plot for someone wanting to reassure themselves about how well get_peaktable works Ben

From: Ethan Bass @.> Reply to: ethanbass/chromatographR @.> Date: Wednesday, 30 August 2023 at 12:43 To: ethanbass/chromatographR @.> Cc: Ben Moore @.>, Author @.***> Subject: [External] Re: [ethanbass/chromatographR] stripplot failure in get_peaktable (Issue #28)

Hi Ben, Thank you very much for pointing this out. It seems I broke the code for the plot a while ago, but I didn't realize it since I don't use that plot very often. This should be fixed by 53bec5ehttps://github.com/ethanbass/chromatographR/commit/53bec5ef75e34d6955cea912496618a692b326ea. I also added a test so I will notice if it breaks again. I think it should work for you now after you reinstall from the master branch (and reset your R session). Let me know! Ethan

— Reply to this email directly, view it on GitHubhttps://github.com/ethanbass/chromatographR/issues/28#issuecomment-1698403838, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7RAOHFKBKDKNMZMT3VDWWDXX2RXVANCNFSM6AAAAAA4DXXPPI. You are receiving this because you authored the thread.Message ID: @.***>

ethanbass commented 1 year ago

Yes, thanks again for pointing this out and glad to hear it's working now! Ethan