ethanblake4 / dart_eval

Extensible Dart interpreter for Dart with full interop
https://pub.dev/packages/dart_eval
BSD 3-Clause "New" or "Revised" License
323 stars 36 forks source link

Add support for Sets #2

Open ethanblake4 opened 3 years ago

ethanblake4 commented 3 years ago

This will need: Support in the parser (parser.dart) A new EvalSet type in primitives.dart A new DartSetLiteral class in literals.dart ???

wrbl606 commented 11 months ago

Hi, are the points above still applicable? I'm planning to contribute and think that sets would be a good start.

ethanblake4 commented 11 months ago

Ah not really, this issue is quite old. For Sets, you'd probably need to:

To be frank this is slightly complicated for a first issue at this point since it touches all three parts of dart_eval (compiler, standard library, and runtime). It is doable but I might suggest #4 or #91 first. (Thanks for your interest in contributing btw!)

wrbl606 commented 11 months ago

You're right, I thought that it'll be easier to do (somehow) 😀 Thanks for the explanation!

Noobware1 commented 10 months ago

Hi, @ethanblake4 i can do the 2 and 3 points you said.

The 1st and 4th are just beyond me. If you could elaborate just on them 🙏🙏 it would be big help.