search

ethanc8 / GitUp

The Git interface you've been missing all your life has finally arrived.
http://gitup.co
GNU General Public License v3.0
3 stars 0 forks source link

Current blockers #1

Open ethanc8 opened 6 months ago

ethanc8 commented 6 months ago

Here are the current blockers:

ethanc8 commented 5 months ago

The CAAction protocol version being invalid has been fixed.

Right now, GitUpKit and the examples (GitY, GitDown, and GitDiff) build. GitY doesn't allow you to select repositories (the file picker only allows picking files), and GitDown and GitDiff allow selecting repositories and closing them but the actual diff interface is completely missing (the main window is empty). I think some of GitUpKit's unit tests fail, but I'm not sure exactly why.

ethanc8 commented 5 months ago

Here's how GitDiff looks like right now after selecting a repository:

image

Screencast_20240614_142609.webm

It's supposed to look like this on macOS:

image

(I don't currently have access to a macOS machine, so I can't test it right now).

ethanc8 commented 5 months ago

Note that this was after I patched the AppDelegates' -applicationShouldTerminateAfterLastWindowClosed: to return NO instead of YES:

- (BOOL)applicationShouldTerminateAfterLastWindowClosed:(NSApplication*)sender {
  return NO;
}

Before, when they returned YES, the app immediately quit after selecting the repository, without any explanation.

ethanc8 commented 5 months ago

Updating gnustep-gui doesn't seem to do anything. I'm currently building from https://github.com/ethanc8/libs-gui/tree/ethanc8-6.