ethanchewy / PythonBuddy

1st Online Python Editor With Live Syntax Checking and Execution
https://pythonbuddy.com
BSD 3-Clause "New" or "Revised" License
277 stars 84 forks source link

Fix Line Number Error on Restricted Python branch #12

Closed ethanchewy closed 5 years ago

ethanchewy commented 7 years ago

Here's the branch that needs to be fixed: https://github.com/ethanchewy/PythonBuddy/tree/restrictedpython

Error is pretty simple. The code runs fine and is linted. The line numbers just have to be adjusted correctly. Right now, it displays negative line numbers

To contribute:

Contributors who are approved for pull requests and make significant contributions will be attributed in the Contributing.md file

MarkFilus commented 7 years ago

I'll fix it.

MarkFilus commented 7 years ago

ok this works #14

ethanchewy commented 7 years ago

@MarkFilus You didn't fix it. Try running it on your local machine and testing it with various errors first. I left some comments on your pull request.

Thanks for trying though.

derekwilling commented 5 years ago

Can you provide screenshot of issue? I'm running it and don't see the negative line numbers.

image

ethanchewy commented 5 years ago

@DirtySoc Yeah, so this is an old issue that is no longer relevant.

RestrictedPython is very inflexible and now basically unusable for my use case.

Here's a better approach to sandboxing Python: https://github.com/ethanchewy/PythonBuddySandboxed