ethanchewy / PythonBuddy

1st Online Python Editor With Live Syntax Checking and Execution
https://pythonbuddy.com
BSD 3-Clause "New" or "Revised" License
277 stars 84 forks source link

fix #12, fix #7, improve #11, fix idention, fix multiuser ability #15

Closed devkral closed 6 years ago

devkral commented 7 years ago

Hello, here some improvements to your code. I removed the temp.py hack entirely especially because it is not multiuser compatible (tempfile). Further improvements are idented html code (the few whitespaces will eat no-ones dataplan) Maybe a better idented js code would be helpfull. I used RestrictedPython instead pypy (it's much smaller) The getitem and getiter of it are not safe yet; they are just a hack. Anyway have a look into git submodules; you don't need to put the pypy files in your repo. Everything can be linked

ethanchewy commented 7 years ago

This looks great! Thanks so much.

The only thing I found annoying about RestrictedPython is that it is quite limited in its functionality so I'll have to test it in more depth in our testing branch.

Could you open a different pull request to the Testing branch first?

devkral commented 7 years ago

of course, see https://github.com/ethanchewy/PythonBuddy/pull/18