ethand91 / mediasoup3-record-demo

Simple Record Demo using Mediasoup 3 and GStreamer
198 stars 93 forks source link

Fix compatibility with mediasoup-client >=3.6.45 #77

Closed arzeth closed 2 years ago

arzeth commented 2 years ago

For context: https://github.com/versatica/mediasoup-client/commit/325cea2dcd21456c862feae52521c2cf7f2e450b and specifically https://github.com/versatica/mediasoup-client/commit/b3902d859ff8533758913f4c3be9f7d2a8f7bd41

With this commit of mine, the backend sends role=client to the browser, then the browser sends role=server to the backend's handleTransportConnectRequest.

Without this commit, the backend sends role=server, then the browser sends role=client.

Without this commit, the browser drops the connection (ICE?) in 5000 ms in ~97% cases (I don't know why it works in ~3% cases), and not a single video/audioframe gets ever sent by the browser. By "drops" I mean nothing happens for 5000 ms and then sendTransport.on('connectionstatechange') receives disconnected.

ethand91 commented 2 years ago

Merged! Thanks :)