search

ethanent / phin

Node HTTP client
MIT License
576 stars 33 forks source link

Changed var to let #14

Closed clementallen closed 6 years ago

clementallen commented 6 years ago

Updated var to let to keep inline with the rest of the es6 syntax and removed unnecessary quotes in options object

Rush commented 6 years ago

Change to const while you're at it

clementallen commented 6 years ago

@Rush that wouldn't work as those variables are re-assigned in the code. Variables declared with const cannot be reassigned.

ethanent commented 6 years ago

Thanks for the suggestions! You'll see most of these changes reflected in release 2.7.0 (0b2166249ef8fb1f9f2c2b3d549b1c3b82020086)! 🎉