search

ethanent / phin

Node HTTP client
MIT License
576 stars 33 forks source link

ci: test Node.js 8, 10 and 11 #24

Closed DanielRuf closed 5 years ago

DanielRuf commented 6 years ago

Currently Node.js 6, 8 and 10 are LTS as there is always more than one active LTS branch.

Travis CI used the last LTS branch when lts/* is used which does not include Node.js 8 (which is still used on many platforms) or Node.js 6.

DanielRuf commented 6 years ago

So it does not work on Node.js 6 LTS. We should make this clear in package.json.

DanielRuf commented 6 years ago

See https://github.com/nodejs/Release/blob/master/README.md as Node.js 6 LTS is supported until April 2019.

ethanent commented 5 years ago

Thank you for the PR!

Will look into adding testing for Node 8, 10, and 11 in an upcoming commit.