search

ethanent / phin

Node HTTP client
MIT License
576 stars 33 forks source link

Deprecated usage of node _headers #49

Closed JoaquinFernandez closed 3 years ago

JoaquinFernandez commented 4 years ago

Describe the bug

According to Node.js Deprecated APIs, OutgoingMessage.prototype._headers in v12 has been deprecated and on the other hand i see some deprecation logs while using Axios.

(node:89822) [DEP0066] DeprecationWarning: OutgoingMessage.prototype._headers is deprecated

To Reproduce Calling an endpoint in Node.js v12

Environment:

Phin Version: 3.4.1 OS: OSX 10.15

Related Links

https://stackoverflow.com/questions/56697360/how-to-fix-node12388-dep0066-deprecationwarning-outgoingmessage-prototype https://nodejs.org/api/deprecations.html#deprecations_dep0066_outgoingmessage_prototype_headers_outgoingmessage_prototype_headernames http-party/http-server#537

ethanent commented 4 years ago

Odd. To my knowledge, _headers is not being accessed directly by Phin or Centra. I assume this is a mistake on the part of the implementation of the warning message.

ethanent commented 3 years ago

Closing til further confirmation is available. I don’t think Phin or Centra access _headers, so perhaps this was an issue with another package.