Contribution Guide - Githubissues

ethanent / phin

Node HTTP client

MIT License

576 stars 33 forks source link

Contribution Guide #53

Open ktalebian opened 4 years ago

ktalebian commented 4 years ago

Hello, I was going to open a PR for both phin and centra and add a few improvements:

Replace forEach with for-loop for performance reasons
Remove unnecessary else
Use of const over let
Migrate to use TypeScript

Is there a contribution guide or should I just open a PR and put it up for review? Also, I've noticed the codebase does not use any linter. Any interest in adding one?

ethanent commented 4 years ago

Thanks for the suggestions. Sure, adding a linter could be helpful. I'm not really able to experiment with that too much right now, so a PR would be very much appreciated.