Incorrect TypeScript "data" type declaration

ethanent / phin

Node HTTP client

MIT License

576 stars 33 forks source link

Closed nikitaeverywhere closed 3 years ago

nikitaeverywhere commented 4 years ago

Hello! My TypeScript complains on the very first example you provide in the readme:

I guess this type declaration has to be either Object (it has toString already) or { [key: string]: any, toString(): string }.

What do you think? I will be happy to make a PR.

Thanks for great work.

Sazzo commented 4 years ago

Same here ^

ethanent commented 4 years ago

Thanks! A PR would be much appreciated if anyone is interested.

jdforsythe commented 3 years ago

Fixed in #65

andreasonny83 commented 3 years ago

Please, release a new version with the fix