ethanent / phin

Node HTTP client
MIT License
576 stars 33 forks source link

Package deprecated #91

Closed ethanent closed 8 months ago

ethanent commented 9 months ago

Please reply if you have any questions about Phin's deprecation.

Some popular alternatives (no endorsement, I may not have used them) include:

Please migrate to another HTTP request solution at your earliest convenience.

yetzt commented 9 months ago

But why?

ASaiAnudeep commented 8 months ago

@ethanent could you help us understanding the reason behind deprecating this package. Let me know if we can maintain phin and centra under our org - https://github.com/pactumjs

yetzt commented 8 months ago

i made a fork, pulled in centra, fixed some bugs, added features, ~removed the tests for now because the testing library (whew) was unpublished too...~ ported the tests; it's pretty much a drop in replacement, i will use it in my own packages and implement updates and fixes as needed.

feel free to use it, send pull requests or give feedback.

XuluWarrior commented 8 months ago

@yetzt It would be good know what bugs were fixed and what features were added :)

XuluWarrior commented 8 months ago

Regarding the deprecation of this package, I note in the npm stats that it has 1 million weekly downloads. It would be great if there was a (semi)official continuation of this project with a new maintainer (@yetzt's efforts are already appreciated)

yetzt commented 8 months ago

It would be good know what bugs were fixed and what features were added :)

88 (compressed streams throw exception), #78 (redirect limit) and #79 (centra query is not exposed)

i'm looking into the other issues as well.

ethanent commented 8 months ago

Hi all, version 4.0.0 of the library has been released which uses Axios under the hood and is not deprecated currently. Give it a try! Thanks for your comments.

jdforsythe commented 8 months ago

Hi all, version 4.0.0 of the library has been released which uses Axios under the hood and is not deprecated currently. Give it a try! Thanks for your comments.

If axios was suggested as an alternative, but now this uses axios under the hood, what is this providing that axios doesn't?

sleeyax commented 8 months ago

This situation is being handled poorly, OP. You're not answering any questions about the deprecation (like you said you would) and there are infinitely better options than just republishing axios... It's like no thought was put into this at all.

I recommend to unpublish v4 and transform this issue into a discussion so we, as a community, can figure out the future of this package. Together. Communication is key in open source.

ethanent commented 7 months ago

Hi! Let's move the discussion about v4 to #92. Thank you.

ethanent commented 7 months ago

Maintainers wanted: #94