ethanfetaya / NRI

Neural relational inference for interacting systems - pytorch
MIT License
732 stars 157 forks source link

my_softmax #25

Closed cankucuksozen closed 3 years ago

cankucuksozen commented 3 years ago

Why does the my_softmax function seems to be normalizing alongside the batch dimension instead of classes dimension?

wang422003 commented 3 years ago

Hi! Have you found any possible explanation for the my_softmax? I am quite confused about this one. Maybe I missed some details in the paper.

ethanfetaya commented 3 years ago

I think that was done because at that time the pytorch softmax did not have a dim input variable as it does now.

On Fri, May 28, 2021 at 4:38 PM Aoran Wang @.***> wrote:

Hi! Have you found any possible explanation for the my_softmax? I am quite confused about this one. Maybe I missed some details in the paper.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ethanfetaya/NRI/issues/25#issuecomment-850425344, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG6XQQDXEZB424FXEKZMSTTP6ME5ANCNFSM4PNRMHAQ .

wang422003 commented 3 years ago

Many thanks!

I think that was done because at that time the pytorch softmax did not have a dim input variable as it does now. On Fri, May 28, 2021 at 4:38 PM Aoran Wang @.***> wrote: Hi! Have you found any possible explanation for the my_softmax? I am quite confused about this one. Maybe I missed some details in the paper. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG6XQQDXEZB424FXEKZMSTTP6ME5ANCNFSM4PNRMHAQ .