Implement better patches

ethangreen-dev / lovely-injector

A runtime lua injector for games built with LÖVE

MIT License

78 stars 11 forks source link

Closed flakywanderer closed 3 months ago

flakywanderer commented 4 months ago

As suggested in #52 , use split_inclusive and raw_lines consistently.
Add some flags to regex patches so they are multi-line, and smartly pad insertions to avoid accidentally concatenating to identifiers (they can still be intentionally concatenated to using explicit capturing of the identifier)
Implement multi-line pattern patches

english5040 commented 4 months ago

It looks like you used rustfmt on some files? To be honest the whole thing should be standardized with rustfmt

english5040 commented 4 months ago

hey, sorry. I'll take a second look at the logic, not just formatting, later. the rustfmt changes are just a bit annoying, but I can deal

flakywanderer commented 4 months ago

It looks like you used rustfmt on some files? To be honest the whole thing should be standardized with rustfmt

Yes, I did.

english5040 commented 4 months ago

hey, your PR is great- I am pretty particular about style, sorry. Do need to do the check for bad concatenation last though

flakywanderer commented 3 months ago

How is this looking right now?

flakywanderer commented 3 months ago

Anything more?

ethangreen-dev commented 3 months ago

Chatted with @english5040, your changes look good. Excellent work!