search

ethanhs / cce

commandline compiler explorer - use https://godbolt.org from your terminal!
MIT License
196 stars 14 forks source link

Allow for other CE instance + create URL #4

Closed dkm closed 6 years ago

dkm commented 6 years ago

This should fix #1 and #3 .

I've also took the liberty of using a different mecanism for building JSON that is sent over the POST. It had the advantage to be easily copy/pasted across the python and shell script I'm already using :D

dkm commented 6 years ago

rebased and pushed !

ethanhs commented 6 years ago

Excellent, thank you! I will merge once CI go green.

dkm commented 6 years ago

I've added a single commit for updating the README (very basic).

ethanhs commented 6 years ago

Thank you so much!

dkm commented 6 years ago

Thanks for merging :)

For my information, how did you merge it ? Usually, merging PR maintains original commits (and authorship -- in this case, github changed the mail), but it seems that in this case all my commits were squashed before merging ? It's not really a problem in this case as it's rather small, but more by curiosity.

ethanhs commented 6 years ago

There is an option to squash and merge on Github if you hit the arrow next to the merge button. It's the default several other projects I work on use, so its somewhat become habit for me :)

FWIW authorship stays the same, it just mentions I committed. image

dkm commented 6 years ago

Ok 😃 But authorship is changed. In my case, my workmail has been changed by my personnal mail. It's good to know as it can be an issue for attribution (ie. when work being contributed is paid by my employer, he wants to be credited).

ethanhs commented 6 years ago

Ah, well if you want I wouldn't be opposed to adding an ACKS file for acknowledgements.

dkm commented 6 years ago

No no, that's fine 😃