ethanluoyc / yechuandanmu

A Flask app using Socket.IO to display live Danmaku
2 stars 0 forks source link

Danmu player: Font size and danmu covering #7

Closed JoeyTeng closed 8 years ago

JoeyTeng commented 8 years ago
  1. Could not change the font size of danmu.
  2. Danmu will cover each other (Nico-Nico style). Need an option to switch to "bilibili style" (prevent covering)
ethanluoyc commented 8 years ago

This is a rather complex issue. I currently use an open library for the Danmu, which means that the logic for displaying the Danmus are handled by that library. I want to write a danmaku player myself but haven't not find the time to do it. Let me think about it and get you back on this

JoeyTeng commented 8 years ago

I find the configuration in "danmu.js", I think we could edit that. E.g, currently the height and font size are randomly chosen by the program, we may add a variable to save the lowest height without overlapping.

On Thursday, 21 July 2016, Ethan Luo notifications@github.com wrote:

This is a rather complex issue. I currently use an open library for the Danmu, which means that the logic for displaying the Danmus are handled by that library. I want to write a danmaku player myself but haven't not find the time to do it. Let me think about it and get you back on this

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137220, or mute the thread https://github.com/notifications/unsubscribe-auth/AL8ciJOkJ_JPucQqPleQh2zM81wLZ2IMks5qXtQ6gaJpZM4JPraQ .

ethanluoyc commented 8 years ago

I'm a bit confused as to why setting the lowest height can fix it. I haven't taken a look into danmu.js for quite some time. But if u are confident that this will fix the problem. Feel free to amend it and fix it (so we can close this) Sent from my iPhone, sorry for the brevity.

On Thu, Jul 21, 2016 at 10:10 AM +0800, "Joey Teng" notifications@github.com wrote:

I find the configuration in "danmu.js", I think we could edit that. E.g,

currently the height and font size are randomly chosen by the program, we

may add a variable to save the lowest height without overlapping.

On Thursday, 21 July 2016, Ethan Luo notifications@github.com wrote:

This is a rather complex issue. I currently use an open library for the

Danmu, which means that the logic for displaying the Danmus are handled by

that library. I want to write a danmaku player myself but haven't not find

the time to do it. Let me think about it and get you back on this

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub

https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137220,

or mute the thread

https://github.com/notifications/unsubscribe-auth/AL8ciJOkJ_JPucQqPleQh2zM81wLZ2IMks5qXtQ6gaJpZM4JPraQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

JoeyTeng commented 8 years ago

I mean the height for one certain danmu. I will check the grammar of js and try it these days.

On Thursday, 21 July 2016, Ethan Luo notifications@github.com wrote:

I'm a bit confused as to why setting the lowest height can fix it. I haven't taken a look into danmu.js for quite some time. But if u are confident that this will fix the problem. Feel free to amend it and fix it (so we can close this) Sent from my iPhone, sorry for the brevity.

On Thu, Jul 21, 2016 at 10:10 AM +0800, "Joey Teng" < notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I find the configuration in "danmu.js", I think we could edit that. E.g,

currently the height and font size are randomly chosen by the program, we

may add a variable to save the lowest height without overlapping.

On Thursday, 21 July 2016, Ethan Luo <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

This is a rather complex issue. I currently use an open library for the

Danmu, which means that the logic for displaying the Danmus are handled by

that library. I want to write a danmaku player myself but haven't not find

the time to do it. Let me think about it and get you back on this

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub

< https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137220 ,

or mute the thread

< https://github.com/notifications/unsubscribe-auth/AL8ciJOkJ_JPucQqPleQh2zM81wLZ2IMks5qXtQ6gaJpZM4JPraQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137947, or mute the thread https://github.com/notifications/unsubscribe-auth/AL8ciKwB-BNi98YqqRGeZgQrx-vs9IS_ks5qXtWbgaJpZM4JPraQ .

ethanluoyc commented 8 years ago

Thanks, sorry for not being able to help you a lot these few days. Traveling.

Sent from my iPhone, sorry for the brevity.

On Thu, Jul 21, 2016 at 10:14 AM +0800, "Joey Teng" notifications@github.com wrote:

I mean the height for one certain danmu. I will check the grammar of js and

try it these days.

On Thursday, 21 July 2016, Ethan Luo notifications@github.com wrote:

I'm a bit confused as to why setting the lowest height can fix it. I

haven't taken a look into danmu.js for quite some time. But if u are

confident that this will fix the problem. Feel free to amend it and fix it

(so we can close this)

Sent from my iPhone, sorry for the brevity.

On Thu, Jul 21, 2016 at 10:10 AM +0800, "Joey Teng" <

notifications@github.com

javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I find the configuration in "danmu.js", I think we could edit that. E.g,

currently the height and font size are randomly chosen by the program, we

may add a variable to save the lowest height without overlapping.

On Thursday, 21 July 2016, Ethan Luo <notifications@github.com

javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

This is a rather complex issue. I currently use an open library for the

Danmu, which means that the logic for displaying the Danmus are handled

by

that library. I want to write a danmaku player myself but haven't not

find

the time to do it. Let me think about it and get you back on this

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub

<

https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137220

,

or mute the thread

<

https://github.com/notifications/unsubscribe-auth/AL8ciJOkJ_JPucQqPleQh2zM81wLZ2IMks5qXtQ6gaJpZM4JPraQ

.

You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub

https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137947,

or mute the thread

https://github.com/notifications/unsubscribe-auth/AL8ciKwB-BNi98YqqRGeZgQrx-vs9IS_ks5qXtWbgaJpZM4JPraQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

JoeyTeng commented 8 years ago

It's okay. Have a nice trip!

On Thursday, 21 July 2016, Ethan Luo notifications@github.com wrote:

Thanks, sorry for not being able to help you a lot these few days. Traveling.

Sent from my iPhone, sorry for the brevity.

On Thu, Jul 21, 2016 at 10:14 AM +0800, "Joey Teng" < notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I mean the height for one certain danmu. I will check the grammar of js and

try it these days.

On Thursday, 21 July 2016, Ethan Luo <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

I'm a bit confused as to why setting the lowest height can fix it. I

haven't taken a look into danmu.js for quite some time. But if u are

confident that this will fix the problem. Feel free to amend it and fix it

(so we can close this)

Sent from my iPhone, sorry for the brevity.

On Thu, Jul 21, 2016 at 10:10 AM +0800, "Joey Teng" <

notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');

<javascript:_e(%7B%7D,'cvml','notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');');>> wrote:

I find the configuration in "danmu.js", I think we could edit that. E.g,

currently the height and font size are randomly chosen by the program, we

may add a variable to save the lowest height without overlapping.

On Thursday, 21 July 2016, Ethan Luo <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');

<javascript:_e(%7B%7D,'cvml','notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');');>> wrote:

This is a rather complex issue. I currently use an open library for the

Danmu, which means that the logic for displaying the Danmus are handled

by

that library. I want to write a danmaku player myself but haven't not

find

the time to do it. Let me think about it and get you back on this

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub

<

https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137220

,

or mute the thread

<

https://github.com/notifications/unsubscribe-auth/AL8ciJOkJ_JPucQqPleQh2zM81wLZ2IMks5qXtQ6gaJpZM4JPraQ

.

You are receiving this because you commented.

Reply to this email directly, view it on GitHub, or mute the thread.

You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub

< https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234137947 ,

or mute the thread

< https://github.com/notifications/unsubscribe-auth/AL8ciKwB-BNi98YqqRGeZgQrx-vs9IS_ks5qXtWbgaJpZM4JPraQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ethanluoyc/yechuandanmu/issues/7#issuecomment-234138232, or mute the thread https://github.com/notifications/unsubscribe-auth/AL8ciEIEKBjoKDTXmMWWbPSocEGMH12Lks5qXtYxgaJpZM4JPraQ .

JoeyTeng commented 8 years ago

I have use a tricky way to mitigate overlapping problem. Font size is not emergent now.