ethanmoffat / EndlessClient

An open source client for Endless Online written in C#
MIT License
34 stars 16 forks source link

Get Mac OS build working #251

Closed sorokya closed 1 year ago

sorokya commented 1 year ago

Just contains the required changes at the moment. Planning to add some instructions to the README :)

ethanmoffat commented 1 year ago

This is awesome, thanks!

Can you update the README with instructions on how to build from scratch? I don't plan on adding a pipeline to build this since that would require me buying mac hardware, so anyone that wants to use this is going to need to know how to do it

Just read the description lol I'll wait for that change and then merge

sorokya commented 1 year ago

@ethanmoffat build instructions added and some more commits pushed

There are still some issues that'll need to be addressed if you ever want to publish the app I think..

The application bundle (EndlessClient.app)

Also there's some weird issue with code generation. I think it's an upstream issue with this https://github.com/xamarin/xamarin-macios/issues/13087 but I couldn't really find any details. I could open an issue with them and see if they have any ideas. The workaround is in the build instructions for now.

ethanmoffat commented 1 year ago

@sorokya I don't have any plans to provide an official macOS build because I have no way to support it. Unfortunately, the VM I set up is unusable. I could add a pipeline job to produce macOS artifacts but wouldn't have a way to test it or provide fixes in the event something broke on macOS.

I still think this contribution is huge, but actually running the client on macOS is going to be left as an exercise for the reader.