ethanmoffat / EndlessClient

An open source client for Endless Online written in C#
MIT License
35 stars 16 forks source link

Proper alignment of all map and character layers #334

Open samantha-smiles opened 7 months ago

samantha-smiles commented 7 months ago

Issue Description: Characters do not align correctly with a specific chair. This misalignment occurs on the first attempt to sit after launching the initial build.

An image is attached for reference. Screenshot 2024-04-02 161252

Known solution: Close and reopen the application before attempting to sit.

ethanmoffat commented 7 months ago

Sitting on the ground is also slightly misaligned compared with the vanilla client expected:

image

actual:

image
ethanmoffat commented 7 months ago

The offsets are wrong with both fixed and resizable windows, for both chairs and ground sitting, for both main character and other characters.

ethanmoffat commented 2 weeks ago

I'm updating this to a more generic "align things correctly" task. Turns out a lot of things are misaligned beyond just chairs.

Should also create unit test cases to enforce the correct coordinate values so that refactors can be made without causing regressions.