search

ethanmoffat / EndlessClient

An open source client for Endless Online written in C#
MIT License
34 stars 16 forks source link

Chat fixes #358

Closed sorokya closed 1 month ago

sorokya commented 4 months ago

Closes #352

PM recipient not found doesn't play the SFX

I couldn't replicate this. The SFX played for me

Public and Group chat always shows speech bubble over the main character

This was a bug where we were always overwriting the render character with the main character. Now we always find one in _characterRendererProvider.CharacterRenderers with the matching player id

Admin chat does not play sfx when you send a message, only when you receive one

Added sound effect to chat controller when sending message

Group chat does not play sfx when you are on a different map as the sender

We were only looking at party members in the local map repository instead of the party repository before. Now it shows messages from members no matter where they are in game.

PM tab [x] button doesn't work in resizable display mode

I believe this was a render order bug? Seemed like some kinda z-index kind of thing. Adding the Tab clickable area before the close buttons fixed it. I also adjusted the dimensions a bit to match the gfx.

ethanmoffat commented 4 months ago

Closes #352

PM recipient not found doesn't play the SFX

I couldn't replicate this. The SFX played for me

I was having a bunch of issues with PMs, so it might work inconsistently. The chat code was some of the first code I rewrote and it has not aged well.

ethanmoffat commented 4 months ago

Can you add some details to the PR description about why the fixes work? You have the "what" in the commit history, but I'd like a clear line between "I changed this" and "this is the effect"

sorokya commented 3 months ago

@ethanmoffat PR description updated and can you show an example of how you'd replace the FirstOrDefault usage?