Fix iterator invalidation crashes in world dump restore

ethanmoffat / etheos

[Eth]an's [E]ndless [O]nline [S]erver - fork of eoserv project

zlib License

13 stars 8 forks source link

Fix iterator invalidation crashes in world dump restore #36

Closed Cirras closed 2 years ago

Cirras commented 2 years ago

nlohmann::basic_json::erase invalidates iterators at or after the point of erase. This causes segfaults when restoring more than 1 character or guild from a world dump.

See: nlohmann::basic_json::erase