ethanmoffat / etheos

[Eth]an's [E]ndless [O]nline [S]erver - fork of eoserv project
zlib License
13 stars 8 forks source link

Remove nested query arg parsing that was breaking character creation #4

Closed ethanmoffat closed 4 years ago

ethanmoffat commented 4 years ago

Do you know if the Database::ParseQueryArgs method supports both local (@) and global (@@) variables after this change?

Definitely not for @@. My thinking with having the nested call here was so that if you passed in an @ parameter, the value would also get parsed, but I wasn't actually doing anything for the return. Not entirely sure why I checked that in in the first place, or how I tested it and had it working.

BTW - it's a local branch right now, but eoserv.moffat.io is now hosting this with a sql server (on linux) backend if you want to try it out. I'll launch it off master once these PRs get merged. Hope to automate deployment at some point.