search

ethanmoffat / etheos

[Eth]an's [E]ndless [O]nline [S]erver - fork of eoserv project
zlib License
13 stars 8 forks source link

Validate fiance names when buying marriage approval #62

Closed Cirras closed 1 year ago

Cirras commented 1 year ago

If an invalid fiance name with length >16 is sent with the MARRIAGE_OPEN packet, it causes Character::Save to fail.

iandinwoodie commented 1 year ago

What happens in the scenario where Character::ValidName is false? Does it just do nothing without informing anyone that the requested action could not be completed?

Cirras commented 1 year ago

The official client is unable to send an invalid name (official client limits input to a-z characters and length 12). There is no "invalid name" response defined in the protocol for this case, since it can't actually happen. This validation should only fail for crafted inputs by bad actors (or unofficial clients with noncompliant input validation).

iandinwoodie commented 1 year ago

This validation should only fail for crafted inputs by bad actors (or unofficial clients with noncompliant input validation).

Understood. Sounds like current behavior of silently consuming and the ignoring the input is best. Thanks for clarifying.