ethanmsl / incarnate

Skeleton Repo Incarnate-er (simple carnation process)
4 stars 0 forks source link

binary naming inconsistency #1

Closed ethanmsl closed 1 year ago

ethanmsl commented 1 year ago

_m1 vs _x86 _m1 ~~> _arm, as m1 is no longer the only machine using that architecture.

This is just a naming style point, but will come in handy.

Probably doesn't warrant immediately changing the homebrew-incarnate ruby file, but at least at the time of next release it probably worth changing

ethanmsl commented 1 year ago

Resolved.

Binary naming made consistent.

Current available binaries end tagged with build related information of _apple_aarch64 or _apple_x86_64

(Note: 'Aarch' & 'Arm' refer, in this case, to the same architecture. "Aarch" being used by the LLVM community and "ARM" being used by apple. Aarch being a sub-architecture introduced in Armv8. As we are using an LLVM based compiler and Aaarch is more specific, but applies to all the architectures we're building for I am preferncing, without prejudice, that terminology.)