ethanpartida / MMM-MyStudyLife

Module to display info from the website MyStudyLife
MIT License
10 stars 1 forks source link

Module stuck loading #3

Closed AndrewHulse closed 4 years ago

ethanpartida commented 4 years ago

I'm assuming since you closed this you were able to figure it out. If you run into any issues or there are any parts of the module you want improvements on just let me know I'd be happy to help!

AndrewHulse commented 4 years ago

I did figure out my problem! It was a little dumb mistake on my part. One thing I would like to be able to change is the sizing of text per module. It seemed to have inconsistent size which made it hard to read on a smaller screen. I noticed it mostly with class list with the classes being different from the rest. As well as the text for exams being super small depending on how zoomed my screen is. I’m not sure if this was intentional or not but just wondering. Trying to learn more about raspberry pi’s so I don’t know a whole lot about configuring these sort of things.

On Tue, Apr 28, 2020 at 12:12 PM Ethan Partida notifications@github.com wrote:

I'm assuming since you closed this you were able to figure it out. If you run into any issues or there are any parts of the module you want improvements on just let me know I'd be happy to help!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ethanpartida/MMM-MyStudyLife/issues/3#issuecomment-620705294, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKK6WZLYKFWZZR5LKKVNADRO3567ANCNFSM4MSNFG2A .

-- -Andrew Hulse Mechanical Engineering Student

ethanpartida commented 4 years ago

Alright, I will take a look at that. Some of the CSS, which controls things like font size, is very patchwork. I'm in the middle of finals right now so I don't have much time currently, but I will get to it soon. Thanks for your feedback!

AndrewHulse commented 4 years ago

Alright sweet! I just finished my finals but wish you the best of luck! Can’t wait to see future progress with the module!

On Wed, Apr 29, 2020 at 3:07 PM Ethan Partida notifications@github.com wrote:

Alright, I will take a look at that. Some of the CSS, which controls things like font size, is very patchwork. I'm in the middle of finals right now so I don't have much time currently, but I will get to it soon. Thanks for your feedback!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ethanpartida/MMM-MyStudyLife/issues/3#issuecomment-621404977, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKK6W3GSJZCJZ4SHCM4K23RPB3F7ANCNFSM4MSNFG2A .

-- -Andrew Hulse Mechanical Engineering Student

ethanpartida commented 4 years ago

Hi Andrew, Sorry for the delay. I pushed some changes to the master branch which should address the issues you were having (To receive these changes type "git pull" into a terminal with the MMM-MyStudyLife directory selected).

I should have it in the readme shortly but here is a quick summary of what I did:

Let me know if you encounter any issues or have any other feedback.

Best, Ethan Partida

AndrewHulse commented 4 years ago

Alright sweet! I’ll give it a look in a couple of days and I will let you know if I have any issues! Good work! Thank you, Andrew

On Tue, May 12, 2020 at 9:10 PM Ethan Partida notifications@github.com wrote:

Hi Andrew, Sorry for the delay. I pushed some changes to the master branch which should address the issues you were having (To receive these changes type "git pull" into a terminal with the MMM-MyStudyLife directory selected).

I should have it in the readme shortly but here is a quick summary of what I did:

  • I created config variables called classFontScale, examFontScale, taskFontScale. These will scale the font size of classes, exams, and tasks respectively. The higher number the larger font (1 is the default).
  • I also created a config variable called averageScheduleHeight. This will allow you to specify exactly how many pixels long the schedule will be. This should help fix some problems that occurred on horizontal monitors. The default for this is 600.
  • Lastly I created config variables minClassHeight, maxClassHeight. These specify the min and max percentage of the schedule height a class can be, regardless of its relative length of time. These defaults are 15 and 50 respectively.

Let me know if you encounter any issues or have any other feedback.

Best, Ethan Partida

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/ethanpartida/MMM-MyStudyLife/issues/3#issuecomment-627684287, or unsubscribe https://github.com/notifications/unsubscribe-auth/APKK6W7CDLTID7TUY5QHTZTRRHXP7ANCNFSM4MSNFG2A .

-- -Andrew Hulse Mechanical Engineering Student