search

ethanrae / gtalksms

Automatically exported from code.google.com/p/gtalksms
0 stars 0 forks source link

contacts matching doesn't work as expected when multiple substring matches #347

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. create contacts "Martin" and "Martina Aaaa" on the phone
2. type command "chat:Martin"
3. chat room with contact "Martina Aaaa" will open

What is the expected output?

Chat room with exact match: contact "Martin" will open. When there are no exact 
matches gtalksms should prompt print possible matches and ask for exact request.

What do you see instead?

Chat room with contact "Martina Aaaa" will open.

The same bug is present in other commands where contact matching is performed. 
I already sent few smses to wrong people with the sms command.

Additional informations:
Phone model: HTC One V

Original issue reported on code.google.com by matej.s...@gmail.com on 26 Dec 2013 at 8:56

Attachments:

GoogleCodeExporter commented 9 years ago 
Hello

Does "Martina Aaaa" has a mobile phone set ? and not "Martin"?

The priority is set to contact with mobile phones

Original comment by Florent....@gmail.com on 27 Dec 2013 at 11:42

GoogleCodeExporter commented 9 years ago 
Both are mobile contacts. Actually I have 7 mobile contacts with he substring 
"Martin".

Original comment by matej.s...@gmail.com on 28 Dec 2013 at 11:47

GoogleCodeExporter commented 9 years ago 
Sorry for the long delay...
I mean does the mobile phone number of your contact is marked as "mobile" (and 
not "work", "home" or "custom")?

The application checks the kind of number to put the priority.
So if "Martina aaaa" number is a "mobile" number and "Martin" number is a 
"home" number, the application will choose the first one.

Original comment by Florent....@gmail.com on 18 Feb 2014 at 11:41

GoogleCodeExporter commented 9 years ago 
I didn't understand that you are asking for "category" of the contact. Most of 
my contacts are marked as "unknown" and yes, it works exactly as you described. 

However the outcomes of the algorithm are unfortunate in my and similar cases. 
Shouldn't the commands that are working without confirmation (e.g. sms:) accept 
exact matches only?

Original comment by matej.s...@gmail.com on 24 Feb 2014 at 12:30