search

ethanresnick / json-api

Turn your node app into a JSON API server (http://jsonapi.org/)
GNU Lesser General Public License v3.0
268 stars 41 forks source link

Allow to use json-api with mongoose@6 as peer dependency #214

Closed irnc closed 2 months ago

irnc commented 3 years ago

mongoose@6 works as expected, no issues was observed.

I would be happy to update it in devDependencies also, but I am not sure of your upgrade policy: should json-api target latest mongoose or a wide range including previous major releases. Please advice me on target versions for mongoose.

codecov[bot] commented 3 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.11%. Comparing base (745d36d) to head (a7ca21a). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #214 +/- ## ======================================= Coverage 91.11% 91.11% ======================================= Files 58 58 Lines 2250 2250 Branches 500 500 ======================================= Hits 2050 2050 Misses 200 200 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.