search

ethanresnick / json-api

Turn your node app into a JSON API server (http://jsonapi.org/)
GNU Lesser General Public License v3.0
268 stars 41 forks source link

Remove media type check #79

Closed carlbennettnz closed 9 years ago

carlbennettnz commented 9 years ago

Closes #78

ethanresnick commented 9 years ago

Thanks for this. However, I don't think we want to remove all parameter checks entirely, as it's still important that other parameters cause errors. Instead, we just need to ignore the charset parameter. In other words, I think all that's needed here is a delete contentType.parameters.charset on line 9, and then a test that charset is properly ignored.

ethanresnick commented 9 years ago

Awesome! Merged!

Btw, I wrote up a PR for the spec about this today, so hopefully that'll get merged in soon.

carlbennettnz commented 9 years ago

Awesome, thanks Ethan!