search

ethantw / Han

「漢字標準格式」印刷品般的漢字排版框架 Han.css: the CSS typography framework optimised for Hanzi.
https://hanzi.pro/
MIT License
2.42k stars 135 forks source link

`dist` should be ignored on `.gitignore` #94

Closed JLHwung closed 7 years ago

JLHwung commented 7 years ago

The built library should be excluded from the source repository for a reasonable repository history. Ideally we should run git-filter-branch to delete all the history of dist but simple deletion will be also acceptable if many dev branched outstands.

Adding build process to prepublishOnly will ensure end user got dist included in the npm package.

ethantw commented 7 years ago

OK, looks like something worth changing. I’ll dig into it later. 😸

And oops on accidentally clicking onto the ‘close’ button…

JLHwung commented 7 years ago

Hi ethantw,

This issue is open as discussion on src/build separation. If we agree on the plan I can work on a PR later.

ethantw commented 7 years ago

This issue is open as discussion on src/build separation. If we agree on the plan I can work on a PR later.

Yeah, a PR would be nice. Thanks!

ethantw commented 7 years ago

Done! Thanks again!

JLHwung commented 7 years ago

You are very welcome.