soc-pe-bot
commented
5 days ago Team's Response
The error cannot be reproduced.
I tried following the steps listed down on a fresh jar and also tried following the exact commands entered according to the logging message but was unable to recreate the error seen. I initially assumed it may have been that the starting dates of the sample data generated being different, but i retried the steps again after manually editing the test data to reflect the same dates you would get on running the application for the first time on friday (i.e the dates of the sample meeting generated being from 15-11-2024 to 21-11-2024) and was still unable to recreate the error. I did more testing by adding more meetings and deleting the lower index meetings to ensure that the indexes of all meeting will get updated and also tried favouriting and adding contacts in between those commands to ensure that there was no unexpected interaction between those commands and the schedule but in the end I was unable to recreate this error.
Such an error would be a high severity as it impacts the usability of our product and was actually a bug pointed out in alpha testing, the way we went to rectify this issue was to have the Schedule UI refresh whenever a command was successfully execute so that the Schedule should only display the most updated data. The error seems similar to what we faced during alpha where only a portion of the UI was being updated after a command was executed but It should have been fixed.
Items for the Tester to Verify
:question: Issue response
Team chose [response.CannotReproduce]
- [x] I disagree
Reason for disagreement: I do not agree with this verdict. I am not sure how exactly your sample data is generated but it seems to me that there is some variability, and there is some aspect of the real-time current date/time being used that will affect the sample data. I say this as the timing of your meetings seems to have correlation to the actual date-time that I open and run a new jar file.
The screenshots above are clear evidence that the problem exists. During the PE, the only jar file given should have been the correct one and not the alpha version, so it cannot be the case whereby I was on the alpha version.
I have just taken the time to recreate this by reverting my system clock to Nov 15 16:33 and testing the program again. To clarify, I did this on Nov 21 01:15 but set the system date to the time of the PE.
Commands done: (this was all that was required to reproduce the bug, not adding/favouriting contact) clear see d/17-11-2024 delete-schedule 1
Appreciate that the team agrees with me on the severity. I think that the team should give a more thorough look at the issue especially considering how the sample data (which in this case is very pertinent to the bug) is generated based on real-time date and time, which means that the exact time (up to the exact minute, i think!) that the program is run will have a direct impact on whether or not it can be reproduced.
Once again I do not have information on how exactly the sample data is generated but this is all the information I can provide. Trying again with slight variances (in real-time date/time, due to my speed in typing the commands etc.) give varying results, sometimes the bug is reproduced, sometimes it is not.
If it matters, I am on a linux machine but am using Java 17.
As can be seen in the schedule table, here there are 2 meetings with index 3. This makes it confusing as to which meeting would be deleted when User then inputs delete-schedule 3. This would also mean that there would be a case where User would not be able to delete the desired meeting, depending on which one is chosen.
Repeated tests give inconsistent results. As you can see in the image below, another test showed duplicate meetings with index 2 instead.
I am unsure which of the steps below have contributed directly to the bug, but here is how to replicate it. Steps to recreate:
Below is the entire log, from starting the file to resulting in the error. INFO: =============================[ Initializing AddressBook ]=========================== Nov 15, 2024 4:53:33 PM seedu.address.MainApp initConfig INFO: Using config file : config.json Nov 15, 2024 4:53:33 PM seedu.address.MainApp initConfig INFO: Creating new config file config.json Nov 15, 2024 4:53:33 PM seedu.address.commons.core.LogsCenter init INFO: Log level will be set as: INFO Nov 15, 2024 4:53:33 PM seedu.address.MainApp initPrefs INFO: Using preference file : preferences.json Nov 15, 2024 4:53:33 PM seedu.address.MainApp initPrefs INFO: Creating new preference file preferences.json Nov 15, 2024 4:53:33 PM seedu.address.MainApp initModelManager INFO: Using data file : data/addressbook.json Nov 15, 2024 4:53:33 PM seedu.address.MainApp initModelManager INFO: Creating a new data file data/addressbook.json populated with a sample AddressBook. Nov 15, 2024 4:53:33 PM seedu.address.MainApp initModelManager INFO: Creating a new data file schedule.json Nov 15, 2024 4:53:33 PM seedu.address.MainApp initModelManager INFO: Populated with sample ScheduleList. Nov 15, 2024 4:53:33 PM seedu.address.MainApp start INFO: Starting AddressBook V1.2.0ea Nov 15, 2024 4:53:33 PM seedu.address.ui.UiManager start INFO: Starting UI... Nov 15, 2024 4:53:37 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][clear] Nov 15, 2024 4:53:37 PM seedu.address.ui.MainWindow executeCommand INFO: Result: Address book has been cleared! Nov 15, 2024 4:53:38 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][add ] Nov 15, 2024 4:53:38 PM seedu.address.ui.MainWindow executeCommand INFO: An error occurred while executing command: add Nov 15, 2024 4:53:43 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][add n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney] Nov 15, 2024 4:53:43 PM seedu.address.ui.MainWindow executeCommand INFO: Result: New person added: John Doe; Phone: 98765432; Email: johnd@example.com; Address: 311, Clementi Ave 2, #02-25; Tags: [owesMoney][friends]; favourite: false Nov 15, 2024 4:53:53 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][favourite 1] Nov 15, 2024 4:53:53 PM seedu.address.ui.MainWindow executeCommand INFO: An error occurred while executing command: favourite 1 Nov 15, 2024 4:53:55 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][favourite c/1] Nov 15, 2024 4:53:55 PM seedu.address.ui.MainWindow executeCommand INFO: Result: Favourite contact(s) updated: John Doe; Phone: 98765432; Email: johnd@example.com; Address: 311, Clementi Ave 2, #02-25; Tags: [owesMoney][friends]; favourite: true
Nov 15, 2024 4:54:06 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][see d/17-11-2024] Nov 15, 2024 4:54:06 PM seedu.address.ui.MainWindow executeCommand INFO: Result: Sun 17-11-2024 to Sat 23-11-2024 schedule listed! Nov 15, 2024 4:54:15 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][see d/15-11-2024] Nov 15, 2024 4:54:15 PM seedu.address.ui.MainWindow executeCommand INFO: Result: Sun 10-11-2024 to Sat 16-11-2024 schedule listed! Nov 15, 2024 4:54:20 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][see d/17-11-2024] Nov 15, 2024 4:54:20 PM seedu.address.ui.MainWindow executeCommand INFO: Result: Sun 17-11-2024 to Sat 23-11-2024 schedule listed! Nov 15, 2024 4:54:31 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][delete-schedule 6] Nov 15, 2024 4:54:31 PM seedu.address.ui.MainWindow executeCommand INFO: An error occurred while executing command: delete-schedule 6 Nov 15, 2024 4:56:14 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][delete-schedule 0] Nov 15, 2024 4:56:14 PM seedu.address.ui.MainWindow executeCommand INFO: An error occurred while executing command: delete-schedule 0 Nov 15, 2024 4:56:21 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][delete-schedule 7] Nov 15, 2024 4:56:21 PM seedu.address.ui.MainWindow executeCommand INFO: An error occurred while executing command: delete-schedule 7 Nov 15, 2024 4:56:22 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][delete-schedule 6] Nov 15, 2024 4:56:22 PM seedu.address.ui.MainWindow executeCommand INFO: An error occurred while executing command: delete-schedule 6 Nov 15, 2024 4:56:24 PM seedu.address.logic.LogicManager execute INFO: ----------------[USER COMMAND][delete-schedule 1] Nov 15, 2024 4:56:24 PM seedu.address.ui.MainWindow executeCommand INFO: Result: Deleted Event: Meeting 3 on 2024-11-17 at 18:53:33.525569887