search

ethanwangkangen / pe

0 stars 0 forks source link

[DG] Erroneous sequence diagram in DG #9

Open ethanwangkangen opened 1 week ago

ethanwangkangen commented 1 week ago

image.png

The arrow inside the "alt" box, for "throw CommandException"... starts from an ambiguous place. It is unclear whether it is Model or Person that is throwing the Exception.

Another suggestion is that, considering the complexity of the diagram, minimal notation of the sequence diagram may not be advisable as there is some ambiguity involved.

nus-se-bot commented 5 days ago

Team's Response

Duplicate of #1572.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect syntax for UG sequence diagram, add meetings to a schedule feature, implementation.

Description:

Firstly, the "create AddScheduleCommand" is not really a right label for arrows... As in it's not standardised as to the normal function calls. Secondly, "create AddScheduleCommand" should create an AddScheduleCommand, not call the method of AddScheduleCommand. Thirdly, the title for each object is missing a colon :. It is not a class but more of an object.

Screenshots:

image.png

[original: nus-cs2103-AY2425S1/pe-interim#659] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for the response! We agree with the mentioned changes.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]