search

ethanwharris / gnome-nvidia-extension

A Gnome extension to show NVIDIA GPU information
45 stars 7 forks source link

GTK4 Compatibility #181

Closed derenv closed 2 years ago

derenv commented 3 years ago

@ethanwharris I was wondering if there's a plan regarding upgrading the extension for GTK4? I've found some docs that could be helpful migrating:

migrating from GTK3 to GTK4 GTK4 reference manual

I'd be happy to chip in if need be, not sure how much you intend to maintain this extension so thought i'd ask.

ethanwharris commented 3 years ago

Hi @derenv, definitely would be good to upgrade but I'm not currently able to maintain the extension haha. Very happy for you to take a look :smiley: I can add you as a collaborator if that would help?

derenv commented 3 years ago

sure, that'd be great! i'll have a look over the code at some point and see how much needs done.

ethanwharris commented 3 years ago

Cool, invite sent :smiley:

lynerlok commented 3 years ago

Hi @derenv, I post here the error related to the update of Gnome. I have Fedora 34 with Gnome 40 ( gtk4-4.2.1-1.fc34.x86_64 ).

Error: No property border_width on GtkBox

Stack trace:
  _init/Gtk.Widget.prototype._init@resource:///org/gnome/gjs/modules/core/overrides/Gtk.js:45:40
  buildPrefsWidget@/var/home/lynerlok/.local/share/gnome-shell/extensions/nvidiautil@ethanwharris/prefs.js:153:14
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:209:40
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

I hope that can help you, Regards

derenv commented 2 years ago

Hi @derenv, I post here the error related to the update of Gnome. I have Fedora 34 with Gnome 40 ( gtk4-4.2.1-1.fc34.x86_64 ).

Error: No property border_width on GtkBox

Stack trace:
  _init/Gtk.Widget.prototype._init@resource:///org/gnome/gjs/modules/core/overrides/Gtk.js:45:40
  buildPrefsWidget@/var/home/lynerlok/.local/share/gnome-shell/extensions/nvidiautil@ethanwharris/prefs.js:153:14
  _init@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:209:40
  OpenExtensionPrefsAsync/<@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:122:28
  asyncCallback@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:115:22
  run@resource:///org/gnome/Shell/Extensions/js/dbusService.js:177:20
  main@resource:///org/gnome/Shell/Extensions/js/main.js:19:13
  run@resource:///org/gnome/gjs/modules/script/package.js:206:19
  start@resource:///org/gnome/gjs/modules/script/package.js:190:8
  @/usr/share/gnome-shell/org.gnome.Shell.Extensions:1:17

I hope that can help you, Regards

Hi @lynerlok , this should be solved with #182.