search

ethanwharris / gnome-nvidia-extension

A Gnome extension to show NVIDIA GPU information
46 stars 7 forks source link

[Feature Request] Fixed Widths #203

Open AlexvZyl opened 2 years ago

AlexvZyl commented 2 years ago

Currently the updating numbers cause the entire widget to move around when the amount of numbers change, which is distracting in some cases. It would be nice if there could be a fixed widths options, like with Vitals.

AlexvZyl commented 2 years ago

@ethanwharris If you do not have the time for this, let me know and I can give it a shot when I get some spare time.

derenv commented 2 years ago

Could you provide screenshots of Vitals @Alex-vZyl ?

I like the idea, varying fixed width options would be good.. at minimum it should scale to the width of 4 characters for each value by default (3 numerals and a symbol '%' or degrees C etc) which should reduce the issue, with other options allowing gaps in between stats for customisation.

AlexvZyl commented 2 years ago

Here is a screenshot of vitals and nvidia stats: image

Vitals implemented their fixed widths in a dynamic manner. The width is taken as the widest the element has been. So if a value goes from 1% to 10% the element widens and everything moves. The same for going from 10% to 100%. It does not shrink when going from a larger element to a smaller one (100% to 10%), obviously. This makes sense, since vitals has a ton of stuff they monitor, all with different values and units.

However, this causes inconsistencies and some elements are wider than others, and sometimes there are large open white spaces. This can be seen in the first element.

I like your idea of having a fixed width of 4 characters. It is simple and very consistent. It is especially viable since this extension just monitors 4 resources.

derenv commented 2 years ago

@Alex-vZyl I've created a branch (feature-request-fixed-widths) feel free to make pull requests if you want. I plan on having a look at some point, but i'm quite busy atm so if you have the time/energy go for it!

I've got a passthrough VM (i don't use gnome currently) so i can do some validation testing if needed.