ethb3rlin / Submi-ions

Submißions: EthBerlin 2024 submissions and judging tool
GNU General Public License v3.0
8 stars 2 forks source link

[Bug] When Metamask extension is not installed, "Log in with Ethereum" button throws an uncaught exception in the console #10

Open blei-schmetterling opened 6 months ago

blei-schmetterling commented 6 months ago

Not sure why exactly it cannot fetch ETH accounts, but it doesn't fall gracefully: the button appear dead.

Here's what happens in the console:

image

And here's the JS file it complains about:

image

Steps to reproduce:

blei-schmetterling commented 6 months ago

To bypass the issue you need to install https://metamask.io, this part is obvious. The problem is to correctly handle the case when the extension is not there: I'd probably redirect to metamask webpage in this case.