search

ethcatherders / EIPIP

EIP Improvement Process
81 stars 37 forks source link

Agenda request: PR #6483 #215

Closed fulldecent closed 11 months ago

fulldecent commented 1 year ago

Requesting a review please of https://github.com/ethereum/EIPs/pull/6483

This includes several changes furthering the goal of making EIPs useful, and keeping the community together rather than immediately splitting off several EIP groups with their own independent leadership and processes.

(Note that maybe EIPs will be split out, and maybe that is a good thing. Or not. But this is PR addresses immediate problems.)

  1. EIP website is focused on EIPs (currently it is focused on classifications and instructions, boring)
  2. The EIP website gets filters, which can quickly show you want you want to see
  3. RSS feeds are added, addressing a major concern people have about getting inundated with ERC notifications

I am requesting please a review of this PR as a whole as-is without modification as to whether it is a net improvement and whether it should be merged now.

Requesting this feedback on that PR as available---and then as necessary (if not merged) at the next EIPIP meeting.

If such consensus cannot be made to merge the PR as-is, I am alternatively requesting a review of the three specific initiatives above and a commitment to merge (with sufficient quorum/authority) if such a small refactoring of #6483 shall be made.

Pandapip1 commented 1 year ago

Again, I am blocking this PR until 1/2 is split from 3.

Pandapip1 commented 1 year ago

@fulldecent would you mind looking at my rewrite? https://github.com/ethereum/EIPs/pull/6518

I believe this solves your use cases.

fulldecent commented 1 year ago

Thank you for sharing. As for https://github.com/ethereum/EIPs/pull/6518 I left a few notes here.

My concerns in this PR are not addressed by that alternate PR.

Specifically, https://github.com/ethereum/EIPs/pull/6483 addresses the main concern than "ERCs are too noisy". It solves that by making filtering an immediate feature of the website.

Pandapip1 commented 1 year ago

Specifically, ethereum/EIPs#6483 addresses the main concern than "ERCs are too noisy". It solves that by making filtering an immediate feature of the website.

Have you tried https://eips.pandapip1.com/search? It supports filtering:

https://eips.pandapip1.com/search?search=category%3ACore+status%3AReview+selfdestruct

fulldecent commented 1 year ago

On that I do not see a button here for filtering:

Screenshot 2023-02-24 at 17 45 19

Compared to the other, the button is front and center on the homepage

image

(this screenshot is shown in light mode and rest assured that website also works in dark mode)

Pandapip1 commented 1 year ago

Fair enough. I'll add a filter button. Also, it's not buried:

Screenshot 2023-02-24 201507

(Also, what browser is that? It looks cool!)

fulldecent commented 1 year ago

That's Arc. I'll send you an invite code, just DM me @fulldecent or email me. Warning that there is an EXTREME amount of phone-homes which you can block with Little Snitch or similar.

That screenshot is showing search and browse links to show content. The other PR https://github.com/ethereum/EIPs/pull/6483 requires zero clicking and uses the well-known CTRL-F for search. So relatively, the other PR is burried.

Pandapip1 commented 1 year ago

That screenshot is showing search and browse links to show content. The other PR ethereum/EIPs#6483 requires zero clicking and uses the well-known CTRL-F for search. So relatively, the other PR is burried.

The other PR uses the K key to open the search page, so the keybind is not relevant here. Additionally, it does need clicking to use the filters, while mine does not.

poojaranjan commented 11 months ago

Issue closed!